NMS-16204: be explicit about which files are are modifying #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
deejgregor
commented
Oct 26, 2023
•
deejgregor
commented
- NMS-16204: be explicit about which files are are modifying
- Improve error handling a little bit.
- Use the same default admin password for grafana
- Make sure curl is explicit about failures
- Clean up a linting error with the commented-out imagePullSecrets
- Don't always require version bump: we don't always release when merging
- Update README.md with new Helm values, add templates
- Make sure README.md files are up-do-date in CI
And also cleanup some 'echo' commands a little bit.
Escape our `find -name` arguments so they don't get globbed. This isn't a problem in the script based on where it normally runs, but it was a problem when I copied and pasted the find command elsewhere and it wasn't clear why it is was behaving differently. Lastly, tweak an `rm` to not hide errors (it should always succeed).
mershad-manesh
previously approved these changes
Oct 26, 2023
The error was: Error: 12:2 [comments] missing starting space in comment
deejgregor
force-pushed
the
jira/NMS-16204
branch
from
a966695 to
8c8ac43
Compare
mershad-manesh
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.