Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMS-16317: Minion Container: Add way to overlay config files #56

Merged
merged 9 commits into from
Feb 26, 2024

Conversation

mershad-manesh
Copy link
Contributor

@mershad-manesh mershad-manesh commented Feb 15, 2024

Expanding the Minion helm chart by adding a configmap that places files under /minion-etc-overlay folder

Example:
$ cd minion $ echo "Hello World" > etc/hello.txt

Limitations:

  • Only supports flat layout, we don't support folders/subdirectories (This won't work etc/test_folder/test.txt)
  • The configMap cannot be bigger than 1MB
  • We do not support any compression
  • Support latests Container images

@mmahacek
Copy link
Contributor

Once this is tested, minion/README.md should be updated to include a note about adding the overlay directory.

ProjectJYL
ProjectJYL previously approved these changes Feb 16, 2024
Copy link
Contributor

@ProjectJYL ProjectJYL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@mershad-manesh mershad-manesh merged commit 2331a37 into main Feb 26, 2024
1 check passed
@mershad-manesh mershad-manesh deleted the mem/NMS-16317 branch February 26, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants