Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NMS-16365: Dynamically scaling heap memory size #59

Merged
merged 8 commits into from
Mar 11, 2024
Merged

NMS-16365: Dynamically scaling heap memory size #59

merged 8 commits into from
Mar 11, 2024

Conversation

mershad-manesh
Copy link
Contributor

@mershad-manesh mershad-manesh commented Mar 6, 2024 •
edited
Loading

Remove the hard coded memory values (JAVA_MAX_MEM, JAVA_MIN_MEM) and allow the user to pass in JAVA_OPTS from values file.

In addition, I'm removing the extra fsGroups entry from the container level

ProjectJYL
ProjectJYL previously approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@ProjectJYL ProjectJYL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mershad-manesh mershad-manesh dismissed ProjectJYL’s stale review March 11, 2024 15:14

The merge-base changed after approval.

@mershad-manesh mershad-manesh merged commit cf5d5ff into main Mar 11, 2024
1 check passed
@mershad-manesh mershad-manesh deleted the mem/NMS-16365 branch March 11, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProjectJYL ProjectJYL ProjectJYL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mershad-manesh @ProjectJYL