Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash if Cut hole mask spans complete object #1578

Closed
dl3sdo opened this issue Apr 12, 2020 · 1 comment · Fixed by #1579
Closed

Crash if Cut hole mask spans complete object #1578

dl3sdo opened this issue Apr 12, 2020 · 1 comment · Fixed by #1579

Comments

@dl3sdo
Copy link
Member

dl3sdo commented Apr 12, 2020

Steps to reproduce

  1. draw an area object
  2. select it and choose any of the three 'Cut hole' operations
  3. draw a circle, rectangle or free form that contains the selected area completely

Actual behaviour

Mapper crashes

Expected behaviour

Configuration

Mapper Version: v20200411.3
Operating System: Win7x64

@dg0yt dg0yt added this to the v0.9.3 milestone Apr 13, 2020
@dg0yt
Copy link
Member

dg0yt commented Apr 13, 2020

Happens in v0.9.2, too.

dg0yt added a commit that referenced this issue Apr 13, 2020
Fix "cutting out" the whole object.
Use BooleanTools::PathObjects more efficiently.
Resolves GH-1578 (crash if cutting out whole object).
@dg0yt dg0yt linked a pull request Apr 13, 2020 that will close this issue
dg0yt added a commit that referenced this issue Apr 14, 2020
Fix GH-1578 (crash if cutting out whole object).
Fix leaving more than one object.
dg0yt added a commit that referenced this issue Apr 14, 2020
Fix GH-1578 (crash if cutting out whole object).
Fix leaving more than one object.
@dg0yt dg0yt mentioned this issue May 12, 2020
dg0yt added a commit that referenced this issue May 13, 2020
Fix GH-1578 (crash if cutting out whole object).
Fix leaving more than one object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants