-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Border lines do not match area outlines at inner corners #1602
Comments
This one is scary. The outline symbol has zero width and no color assigned. Still, it renders as a 0.2 mm black line! On a closer look, I can see that 521.2 (Large Building Outline) has no width assigned but it does have a border line. Manual setting of proper width and unchecking the border checkbox can be considered as a workaround in this case. Aleš, would you be so kind as to share the original .ocd for easier debugging, please? |
That's one of the corner cases which isn't handle sufficiently at the moment_ A border line on an otherwise invisible line. I guess this was chosen in order to have the object path be the real boundary, making it easy to work with imported data, e.g. from OSM, or to switch from solid black to gray with outline.
Once the issue is corrected, we should consider a similar border configuration for our symbol sets. This might need another tweak: taking care of inside and outside for closed paths. At the moment we only have left side and right side. The corner |
In particular, you see errors with the border at "inner" corners. |
Thank you guys! And you are right this definition was chosen in order to have the object path be the real boundary, making it easy to work with imported data. |
The path of a border line is determined by two factors: the main offset, indicating the edge of the main line, and an explicit additional offset. Mapper used to rely on the main offset being non-zero in order to distinguish left from right by the sign of the main offset. With this change, Mapper now uses the totat offset to determine left or right, thus allowing to use border lines with invisible main lines. Fixes GH-1602 (wrong area border line path).
The path of a border line is determined by two factors: the main offset, indicating the edge of the main line, and an explicit additional offset. Mapper used to rely on the main offset being non-zero in order to distinguish left from right by the sign of the main offset. With this change, Mapper now uses the totat offset to determine left or right, thus allowing to use border lines with invisible main lines. Fixes GH-1602 (wrong area border line path).
The path of a border line is determined by two factors: the main offset, indicating the edge of the main line, and an explicit additional offset. Mapper used to rely on the main offset being non-zero in order to distinguish left from right by the sign of the main offset. With this change, Mapper now uses the totat offset to determine left or right, thus allowing to use border lines with invisible main lines. Fixes GH-1602 (wrong area border line path).
Steps to reproduce
See rect2.zip
Mapper Version: 0.9.2
Operating System: Win, Adroid
The text was updated successfully, but these errors were encountered: