-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some area symbol objects trigger a crash #1608
Comments
Possible fix.
|
@lpechacek Yes, this argument should always be zero, or rather |
Minimal reproducer. The key points are - combined symbol (area+dashed line), line dash longer than the hole in the area, and the hole must have at least one Bézier segment. |
dg0yt
changed the title
Opening OCAD file crashes all MAPPER
Some area symbol object trigger a crash
May 11, 2020
dg0yt
changed the title
Some area symbol object trigger a crash
Some area symbol objects trigger a crash
May 11, 2020
dg0yt
added a commit
that referenced
this issue
May 12, 2020
When renaming a local identifier (to resolve shadowing) in 7c26d51, one usage of the identifier was overlooked, leading to refering to the shadowed parameter instead. This caused out-of-bounds access in a rare but valid combination of circumstances: - A combined symbol with an area subsymbol and a dashed line symbol. - An object with a hole which has at least one Bézier segment. Fixes GH-1608 (Crash when loading file).
Merged
dg0yt
added a commit
that referenced
this issue
May 12, 2020
When renaming a local identifier (to resolve shadowing) in 7c26d51, one usage of the identifier was overlooked, leading to refering to the shadowed parameter instead. This caused out-of-bounds access in a rare but valid combination of circumstances: - A combined symbol with an area subsymbol and a dashed line symbol. - An object with a hole which has at least one Bézier segment. Fixes GH-1608 (Crash when loading file).
dg0yt
added a commit
that referenced
this issue
May 13, 2020
When renaming a local identifier (to resolve shadowing) in 7c26d51, one usage of the identifier was overlooked, leading to refering to the shadowed parameter instead. This caused out-of-bounds access in a rare but valid combination of circumstances: - A combined symbol with an area subsymbol and a dashed line symbol. - An object with a hole which has at least one Bézier segment. Fixes GH-1608 (Crash when loading file).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce
This happens with this OCAD file in attach. Other OCAD files are opening normal. But its worth to check, if something special is making MAPPER to totally crash, since this could be indication of wider problem.
Actual behaviour
Mapper totally crashes.
Expected behaviour
OCAD file is opened.
Configuration
Mapper Version: 0.9.2
Operating System: MacOS
Bargupite_SIkompass-2019.ocd.zip
The text was updated successfully, but these errors were encountered: