Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate line symbol after editing properties, copy, paste #1837

Closed
dl3sdo opened this issue Dec 30, 2020 · 1 comment
Closed

Duplicate line symbol after editing properties, copy, paste #1837

dl3sdo opened this issue Dec 30, 2020 · 1 comment

Comments

@dl3sdo
Copy link
Member

dl3sdo commented Dec 30, 2020

Note: this is similar to #1828

Steps to reproduce

  1. draw an object
  2. edit symbol
  3. copy and paste object

Some affected symbols/properties:

It seems that a lot of properties in line and area symbols are subject to this behaviour.

Actual behaviour

A new symbol is created

Configuration

Mapper Version: master v20201227.4
Operating System: Win7x64

@dg0yt
Copy link
Member

dg0yt commented Dec 30, 2020

It seems that a lot of properties in line and area symbols are subject to this behaviour.

This claim is too broad. 402 is an area symbol, so you just observe #1828 again. And the trigger for 1828 is not a particular property which you change: The trigger is the fact that you change a property in the symbol editor, before copy-and-paste. This explains why nobody noticed this before: a) The symbol editor isn't used so much. b) Without changes, nothing goes wrong. c) For serious work on symbol sets, you will do a copy of the symbol first, not copy-and-paste objects after changing the symbol.

For line symbols (517), the symbol editor creates named PointSymbol for start, mid, dash and end symbol. So it is probably the same bug pattern.

dg0yt added a commit that referenced this issue Dec 30, 2020
dg0yt added a commit that referenced this issue Dec 30, 2020
Treat empty point symbols like null point symbols.
Resolves GH-1837 (duplicate line symbol after edit/copy/paste).
@dg0yt dg0yt changed the title Duplicate symbol after editing properties, copy, paste Duplicate line symbol after editing properties, copy, paste Dec 30, 2020
dg0yt added a commit that referenced this issue Dec 31, 2020
Treat empty point symbols like null point symbols.
Resolves GH-1837 (duplicate line symbol after edit/copy/paste).
@dg0yt dg0yt closed this as completed in 864377a Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants