Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Tourist mode" #987

Closed
ollesmaps opened this issue Oct 9, 2017 · 12 comments
Closed

"Tourist mode" #987

ollesmaps opened this issue Oct 9, 2017 · 12 comments

Comments

@ollesmaps
Copy link

Steps to reproduce

It would be nice for some occasions to have a "Tourist mode". For times when you stroll through terrain faster and need to see your movement on screen legibly.

Expected behaviour

In "Tourist mode" the position dot shall be bigger. The gps position shall be in centre of screen all time. The position line shall be thicker (that can be solved by #986).

@Zerbembasqwibo
Copy link
Contributor

Now when "jump to GPS-position" tool is implemented, I suggest that double or long click on the button will start up "tourist mode". It means the app will autopush on the button every second.

In settings you might implement choises:

  • How often to update: 1,2,3,4,5,10,20,30 sec's from a dropdown list
  • If to lock all other functions/buttons while in this mode (maybe it has to be, what if you draw and the map jumps around by itself? Or use same logic as for autorotate) (yes/no)
  • If to override screen save (yes/no) (if possible)

Default: 1 sec update frequencey, no locking of other tools, yes prevent screen saver to darken the device.

@Zerbembasqwibo
Copy link
Contributor

Anyone else that feels this would be cool/useful?

@lpechacek
Copy link
Member

To be honest, I occasionally recall this ticket while walking through a forest. However, the pressure is not sufficient to make me jump into writing code for this enhancement. So, at the risk of sounding rude, let me remind that Mapper is an open-source project. Anyone can try contributing code. I promise I'll be friendly to the person who comes with the first implementation of this feature.

@Zerbembasqwibo
Copy link
Contributor

Zerbembasqwibo commented Feb 19, 2020 via email

lpechacek added a commit to lpechacek/mapper that referenced this issue May 24, 2020
In tourist mode the map auto-pans so that the GNSS cursor remains around
the center of the screen.

Closes OpenOrienteeringGH-987
@lpechacek
Copy link
Member

@ollesmaps, is the below what you meant?

Tourist mode can be activated after long press on "move to current location".
image

Then the location cursor is free to wander within the central area of the screen and the map gets scrolled only when the cursor would leave the center region.
ezgif com-video-to-gif

Quite naturally, attempts to pan the map view by hand get overridden by the automatic adjustment.

@lpechacek
Copy link
Member

During the next two weeks, I won't have the possibility to test this enhancement in the field. Those interested in trying out tourist mode can download a test build at the location mentioned in #1242 (comment). The test build, identifying itself as OpenOrienteering Mapper git-mobile_ui_gadgets, can be installed alongside the official Mapper release. Any feedback is welcome.

@dg0yt dg0yt pinned this issue May 26, 2020
@ollesmaps
Copy link
Author

@lpechacek
Libor, looks prefect, I will surely test it. Thank you!

@mlerjen
Copy link
Contributor

mlerjen commented May 27, 2020

@lpechacek: Testing the tourist mode the app started zooming in minimum-stepwise ad nauseam resp. until I closed the app. It happened twice. A third try the mode worked as intended. I cannot reproduce the error.

@lpechacek
Copy link
Member

Thanks, Martin, for the report. I'll review the code one more time to see what could have gone wrong.

@ollesmaps
Copy link
Author

It works perfectly well! Some mapping days I have it all time on. It saves time.
One detail: when returning to normal regimen it could say "Stop autopan..." instead of "Autopan..." (sentence from the start).

@ollesmaps
Copy link
Author

As a sidenote: isn't the autopanning a way how to introduce fluent drawing enhancement #988 ?

@dg0yt dg0yt self-assigned this Sep 6, 2020
@dg0yt
Copy link
Member

dg0yt commented Sep 6, 2020

I'm preparing this for merging and releasing with the next master release. I can confirm that unexpected changes of zoom may happen quite regularly. I will try to implement the repositioning a little differently.

dg0yt added a commit that referenced this issue Sep 6, 2020
In this mode the map auto-pans so that the GNSS cursor remains
close to the center of the screen.
Closes GH-987 (tourist mode)

Co-authored-by: Kai Pastor <dg0yt@darc.de>
dg0yt added a commit that referenced this issue Sep 6, 2020
In this mode the map auto-pans so that the GNSS cursor remains
close to the center of the screen.
Closes GH-987 (tourist mode)

Co-authored-by: Kai Pastor <dg0yt@darc.de>
dg0yt added a commit that referenced this issue Sep 6, 2020
In this mode the map auto-pans so that the GNSS cursor remains
close to the center of the screen.
Closes GH-987 (tourist mode)

Co-authored-by: Kai Pastor <dg0yt@darc.de>
@dg0yt dg0yt closed this as completed in 16f1479 Sep 6, 2020
@dg0yt dg0yt unpinned this issue Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants