Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logger (Pino migration and sensitive data handler) #154

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Dec 17, 2024

Main Changes

  • Feat Migrate to Pino (dd2143f) and improve logger levels and initialization (c19e483)
  • Added dependencies:
  • Add more messages to the users when running commands in the CLI (3e40151)
  • Handle sensitive information in the logger (when using containers). This prevent accidental leaks described in Logger Migration to Pino #132 (dd03cbc)

Screenshots

More messages

Screenshot from 2024-12-17 16-40-09

Screenshot from 2024-12-17 16-36-08

Screenshot from 2024-12-17 14-35-47

Clean test

Screenshot from 2024-12-17 17-07-05

Hide sensitive info (GH tokens)

Screenshot from 2024-12-17 16-42-28

Screenshot from 2024-12-17 16-20-49

Context

Changelog

Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/pino-pretty@13.0.0 environment Transitive: filesystem +18 822 kB matteo.collina
npm/pino@9.5.0 environment, unsafe Transitive: eval, filesystem +12 1.19 MB matteo.collina

View full report↗︎

@UlisesGascon UlisesGascon changed the title migrate to pino Improve logger (Pino migration and sensitive data handler) Dec 17, 2024
@UlisesGascon UlisesGascon marked this pull request as ready for review December 17, 2024 16:09
@UlisesGascon UlisesGascon self-assigned this Dec 17, 2024
@UlisesGascon UlisesGascon added the enhancement New feature or request label Dec 17, 2024
@bjohansebas
Copy link
Contributor

Awesome

@UlisesGascon UlisesGascon merged commit 98878a4 into main Dec 17, 2024
3 checks passed
@UlisesGascon UlisesGascon deleted the rework-logger branch December 17, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logger Migration to Pino
2 participants