Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DevEx when doing changes in migrations #33

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Dec 5, 2024

This PR introduce additional information and tasks to the contributors when they make changes to the migration files (demo).

@UlisesGascon UlisesGascon force-pushed the feat/improve-pr-comment branch from 0e6b64e to 0f6e59c Compare December 5, 2024 23:56
Copy link

github-actions bot commented Dec 5, 2024

It looks like you've made changes to the migrations. Thanks for your contribution!

  • Have you run npm run db:generate-schema to ensure the updated schemas are included in your PR?
  • Have you run npm run db:migrate and then npm run db:rollback to confirm that rollbacks are working as expected?

Note: Please avoid making changes to existing migration files, as this will alter the file hash and could break migrations in production environments.

@UlisesGascon UlisesGascon force-pushed the feat/improve-pr-comment branch from 0f6e59c to f525a39 Compare December 5, 2024 23:58
@UlisesGascon UlisesGascon changed the title ci: add action items in the comment when a migration has been added ci: improve DevEx when doing changes in migrations Dec 6, 2024
@UlisesGascon UlisesGascon changed the title ci: improve DevEx when doing changes in migrations Improve DevEx when doing changes in migrations Dec 6, 2024
@UlisesGascon UlisesGascon added this to the MVP Version milestone Dec 6, 2024
@UlisesGascon UlisesGascon self-assigned this Dec 6, 2024
@UlisesGascon UlisesGascon marked this pull request as ready for review December 6, 2024 00:00
@UlisesGascon UlisesGascon merged commit 8c2ad16 into main Dec 6, 2024
1 check passed
@UlisesGascon UlisesGascon deleted the feat/improve-pr-comment branch December 7, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant