Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for githubOrgMFA #44

Merged
merged 12 commits into from
Dec 7, 2024
Merged

Add check for githubOrgMFA #44

merged 12 commits into from
Dec 7, 2024

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Dec 7, 2024

Main Changes

  • Enable check githubOrgMFA in the compliance_checks table (55eaac5)
  • Add check validator for githubOrgMFA (44c41d1)
  • Add check githubOrgMFA (6f1e161)

Add support to future checks

  • Extend utils with getSeverityFromPriorityGroup (c28403e), groupArrayItemsByCriteria (c694ca7) and isCheckApplicableToProjectCategory (30d2d83)
  • Add await to prevent inconsistencies (bug solved) (2ae55af)
  • Extend store to work with alerts, tasks and results (b93f20b)
  • Extend test utils to support Alerts, Results and Tasks operations (ccd41d3)

Other changes

  • Add issue templates (legacy commit from a prior rebase) (8339ca5)
  • Remove placeholder file (fc2ad81)

Related

Changelog

@UlisesGascon UlisesGascon added this to the MVP Version milestone Dec 7, 2024
@UlisesGascon UlisesGascon self-assigned this Dec 7, 2024
@UlisesGascon UlisesGascon changed the title Add check githubOrgMFA Add check for githubOrgMFA Dec 7, 2024
Copy link

github-actions bot commented Dec 7, 2024

It looks like you've made changes to the migrations. Thanks for your contribution!

  • Have you run npm run db:generate-schema to ensure the updated schemas are included in your PR?
  • Have you run npm run db:migrate and then npm run db:rollback to confirm that rollbacks are working as expected?

Note: Please avoid making changes to existing migration files, as this will alter the file hash and could break migrations in production environments.

@UlisesGascon UlisesGascon marked this pull request as ready for review December 7, 2024 04:43
@UlisesGascon UlisesGascon merged commit 6adbd3d into main Dec 7, 2024
2 checks passed
@UlisesGascon UlisesGascon deleted the feat/add-githubOrgMFA branch December 7, 2024 04:46
@UlisesGascon UlisesGascon mentioned this pull request Dec 9, 2024
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant