filter/texttotext.c: link with libiconv if needed #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texttotext.c uses iconv so it should link with libiconv on platforms where it is a separate library (e.g. uClibc-ng without built-in NLS) otherwise texttotext fails to link: CCLD texttotext [...]/ld: texttotext-texttotext.o: in function `main': texttotext.c:(.text.startup+0xde0): undefined reference to `libiconv_open' [...]/ld: texttotext.c:(.text.startup+0xf9d): undefined reference to `libiconv' [...]/ld: texttotext.c:(.text.startup+0xfd6): undefined reference to `libiconv' [...]/ld: texttotext.c:(.text.startup+0x16c3): undefined reference to `libiconv_close' Modify autogen.sh to call autopoint, which adds the libiconv discovery. It also creates a "po" skeleton but we can discard it, since it is not really necessary. Fixes: https://bugs.busybox.net/show_bug.cgi?id=12031 Signed-off-by: Carlos Santos <unixmania@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
texttotext.c uses iconv so it should link with libiconv on platforms
where it is a separate library (e.g. uClibc-ng without built-in NLS)
otherwise texttotext fails to link:
CCLD texttotext
[...]/ld: texttotext-texttotext.o: in function
main': texttotext.c:(.text.startup+0xde0): undefined reference tolibiconv_open'[...]/ld: texttotext.c:(.text.startup+0xf9d): undefined reference to
libiconv' [...]/ld: texttotext.c:(.text.startup+0xfd6): undefined reference tolibiconv'[...]/ld: texttotext.c:(.text.startup+0x16c3): undefined reference to `libiconv_close'
Modify autogen.sh to call autopoint, which adds the libiconv discovery.
It also creates a "po" skeleton but we can discard it, since it is not
really necessary.
Fixes: https://bugs.busybox.net/show_bug.cgi?id=12031
Signed-off-by: Carlos Santos unixmania@gmail.com