request.c: Use errno only if it is non-zero (fixes #893) #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelrsweet
requested changes
Jul 15, 2024
zdohnal
force-pushed
the
use-errno-only-if-set
branch
3 times, most recently
from
8562930
to
fa94eab
Compare
zdohnal
force-pushed
the
use-errno-only-if-set
branch
2 times, most recently
from
a339565
to
b7855aa
Compare
zdohnal
force-pushed
the
use-errno-only-if-set
branch
from
b7855aa
to
dce308e
Compare
michaelrsweet
requested changes
Jul 22, 2024
zdohnal
force-pushed
the
use-errno-only-if-set
branch
from
ffe60df
to
b672448
Compare
Sometimes errno is not set when we want to report HTTP error, so we should use `http->error` if available or internal server error. In cases of internal HTTP related errors where we don't have HTTP connection available (before setting of HTTP connection or in callbacks which process IPP messages), use `_cupsSetError()`. Fixes OpenPrinting#893
zdohnal
force-pushed
the
use-errno-only-if-set
branch
from
b672448
to
8643c97
Compare
|
Currently breaks the build |
|
@andi34 ouch! Thanks! I was too eager there, it should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of internal errors, we use errno for generating error message, but there are cases (like operation timeout for listing drivers or models) when errno is zero.
We should take error from
http->errorif errno is zero, falling back toInternal Server Errorif evenhttp->erroris 0 and still we have HTTP_STATUS_ERROR.Fixes #893