cgi: Fix checkbox support (fixes #1008) #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelrsweet
requested changes
Jul 17, 2024
zdohnal
force-pushed
the
fix-checkbox-support
branch
from
50ea493
to
70439f2
Compare
There was a change in CGI script regarding checkboxes, however it did not propagate into templates. Based on the change, the only valid check was if the variable value was checkbox, but some browsers (at least Firefox) send on as a default value for input form of type checkbox. Additionally, the value checkbox looks like typo, because we use checked as value for checkboxes in admin CGI program, so I updated cgiGetCheckbox() as well. To fix the behavior, we have to set VALUE="CHECKED" into every tag in every templates for all checkboxes - this value will be sent in the input form, so it will properly match with cgiGetCheckbox() logic now. In the end, I have found out "Preserve Job History" checkbox from template was handled as text field, which did not look correct. Fixes OpenPrinting#1008
zdohnal
force-pushed
the
fix-checkbox-support
branch
from
70439f2
to
f37d3eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a change in CGI script regarding checkboxes, however it did not propagate into templates. Based on the change, the only valid check was if the variable value was
checkbox, but some browsers (at least Firefox) sendonas a default value for input form of type checkbox.Additionally, the value
checkboxlooks like typo, because we usecheckedas value for checkboxes in admin CGI program, so I updatedcgiGetCheckbox()as well.To fix the behavior, we have to set
VALUE="CHECKED"into every tag in every templates for all checkboxes - this value will be sent in the input form, so it will properly match withcgiGetCheckbox()logic now.In the end, I have found out "Preserve Job History" checkbox from template was handled as text field, which did not look correct, and implemented default values for dependent options.
Fixes #1008