Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm that -Wl,-pie links on Darwin #303

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Confirm that -Wl,-pie links on Darwin #303

merged 1 commit into from
Dec 7, 2021

Conversation

evanmiller
Copy link
Contributor

The flag compiles but fails to link when the deployment target is OS X 10.4.

The flag compiles but fails to link when the deployment target is OS X 10.4.
Copy link
Member

@michaelrsweet michaelrsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zdohnal
Copy link
Member

zdohnal commented Dec 7, 2021

Hi Evan,

thank you for the PR! Merging...

@zdohnal zdohnal merged commit 52fef29 into OpenPrinting:master Dec 7, 2021
@zdohnal
Copy link
Member

zdohnal commented Dec 7, 2021

@michaelrsweet thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants