Fix uninit value based jump in ppd.c #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdohnal
approved these changes
Feb 9, 2022
| @@ -3430,7 +3430,7 @@ ppd_update_filters(ppd_file_t *ppd, /* I - PPD file */ | |||
| srctype[256], | |||
| dstsuper[16], /* Destination MIME media type */ | |||
| dsttype[256], | |||
| program[1024], /* Command to run */ | |||
| program[1024] = {0}, /* Command to run */ | |||
There was a problem hiding this comment.
The initialization list is used in other places in the code, so the usage is fine.
@rikylescak but all other code in the block are declarations, so I would move the definition of program below it next time.
I'll fix it by myself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
valgrind on ppc64le arch complains about jump based on uninitialized memory in ppd.c