scheduler/printers.c: Don't remove processing temp queue #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cupsdDeleteTemporaryPrinters() deletes temporary queues which their last status was updated 1 minute ago or older. It doesn't take into account the fact the printer can be processing a big print job and cupsd deletes the temp queue either way. The fix in the PR now set cupsd to ignore queues which are in processing state. If the delay in job processing is caused by an error in printer, the correct error should kick in IPP backend.
|
At this specific case the delay in printing was caused by 'printer being busy' (based on https://www.pwg.org/archives/ipp/2015/018399.html) or spool area was really full and the printer stuck. Here is the log. IMHO IPP backend should exit with error after some timeout rather than cupsd cleaning up the queue. @michaelrsweet is there a way how to clear the spooler on the printer by some IPP command? I get similar issue (printer reporting |
|
Thx for the review! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cupsdDeleteTemporaryPrinters() deletes temporary queues which their last
status was updated 1 minute ago or older. It doesn't take into account
the fact the printer can be processing a big print job and cupsd deletes
the temp queue either way.
The fix in the PR now set cupsd to ignore queues which are in processing
state. If the delay in job processing is caused by an error in printer,
the correct error should kick in IPP backend.