-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add device_uri for found network printers (attempt 2) #402
Conversation
Hi @Pro-pra , thank you for the PR! I've verified that I can see device uri once I have my mouse cursor above the entry for network printers. LGTM. @michaelrsweet wdyt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me, but please squash all commits into one.
I don't know how to do it now |
and open new pull request? |
No - there's no need for a new PR... You can do it on the same branch you've used for PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The PR pushed as commit 23cef1c . Thank you for the PR! |
from #397
i add "title" and i see tooltip if mouse over printer name.