backend,scheduler/ipp.c: Fix 'printer-alert' invalid free #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is created by Bernhard Übelacker from apple/cups #5826.
The problem is described in detail here. I just removed:
from the original patch - it looks okay without it (since the attribute is found as IPP_TAG_STRING and the tag doesn't have a case in switch, it will fallback into
default:
case automatically).Regarding PWG standard IPP_TAG_STRING is the correct one -
printer-alert
is defined as octet-string (meaningippAddOctetString
must be used) and IPP_TAG_TEXT tag works withippAddString
, so based on this it looks like IPP_TAG_STRING is the correct one.