scheduler/ipp.c: Fix memory leaks found during #466 #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelrsweet
requested changes
Sep 17, 2022
cups/ppd-cache.c
Outdated
| cupsFilePrintf(fp, "*cupsStringsURI %s: \"%s\"\n", keyword, ippGetString(attr, 0, NULL)); | ||
| } | ||
|
|
||
| if (response) |
There was a problem hiding this comment.
No need to guard this - ippDelete ignores NULL pointers for you.
cups/ppd-cache.c
Outdated
| @@ -5006,6 +5010,9 @@ _ppdCreateFromIPP2( | |||
| unlink(buffer); | |||
| *buffer = '\0'; | |||
|
|
|||
| if (strings) | |||
There was a problem hiding this comment.
Also here - a NULL strings isn't a problem.
zdohnal
force-pushed
the
create_local_leaks
branch
4 times, most recently
from
1cccad4
to
03eb67f
Compare
zdohnal
force-pushed
the
create_local_leaks
branch
from
952ffee
to
4f154cb
Compare
michaelrsweet
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.