scheduler/printers.c: Check for CMYK as well (fixes #421) #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `load_ppd()` we would set the `print-color-mode` to `monochrome` only if the device supported color printing and the default PPD choice for ColorModel was RGB - this broke settings for color printing for models, which use `CMYK` for ColorModel. With this patch we check for CMYK as well. CUPS 3.0-
|
Any update on this? |
|
Since this is a minor change but fixes color printing on Fedora for users using PPDs with CMYK printers, please merge and schedule this for 2.4.3. Related: #451 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
load_ppd()we would set theprint-color-modetomonochromeonly if the device supported color printing and the default PPD choice for ColorModel was RGB - this broke settings for color printing for models, which useCMYKfor ColorModel.With this patch we check for CMYK as well.
CUPS 3.0-