[Fedora] cups.service.in: Use 'notify' service type and run after net… #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…work.target 1) If the service is defined with 'simple' type, the result of 'systemctl' is 0 regardless of actual startup result, because it reports success/failure of forking process (even before cupsd is started). This way errors due bad configuration or programming errors are masked during systemctl invocation. The 'notify' type depends on executable sending a 'Im running' type of message to systemd after successful start and systemctl's return code depends whether this message came or not, which solves the issue. 2) The service needs to be started after all units needed for network.target are activated. This prevents starting cupsd before we have ports ready. Fedora bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1153660 (adding network.target) https://bugzilla.redhat.com/show_bug.cgi?id=1088918 (change of the service type)
|
The next patches depends on the code in this PR, so I'll commit them into the same branch to prevent conflicts between PRs. Other bugs descriptions are within commit messages. |
If an user has a NIS group as SystemGroup in cups-files.conf, then cupsd fails to start if it is activated before ypbind service. Setting 'After=ypbind.service' sets unit's order to cupsd being started after ypbind. Fedora bug: https://bugzilla.redhat.com/show_bug.cgi?id=1494558
michaelrsweet
added
enhancement
michaelrsweet
approved these changes
Nov 25, 2020
|
Thanks for the merge and coding style fix! I really try to follow coding style, even if it doesn't look like that :) . |
|
@zdohnal No worries :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…work.target
The 'notify' type depends on executable sending a 'Im running' type of message to systemd after successful start and systemctl's return code depends whether this message came or not, which solves the issue.
Fedora bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1153660 (adding network.target)
https://bugzilla.redhat.com/show_bug.cgi?id=1088918 (change of the service type)