-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase log level for "Expiring subscriptions..." #578
Conversation
Fixes NixOS/nixpkgs#195090. NixOS systems with Avahi enabled would previously spam the journal with this log message once a second: this hides that spam behind the log level.
@clefru asked in NixOS/nixpkgs#195090 (comment) if https://sourcegraph.com/github.com/OpenPrinting/cups/-/blob/scheduler/main.c?L978-985 is buggy? expecting |
@ju1m Yes, this fix by my judgement just hides the problem. I recompiled cups with debugging symbols, so I can investigate why under my NixOS, the scheduler wakes up every second. I am particularly interested in "select_timeout" and the value in the "why" variable before it returns. Sadly, since I recompiled cups, the issue is gone, and I have not seen the "Expiring subscriptions..." spam for the last 2-3 weeks. If somebody knows how to trigger this regression, please ping me, so I can take it apart. (And yes, the expire_time calculation seems buggy) |
@clefru: Do you have the debug logging on? Does your network have some Avahi traffic? I haven't deployed to my print server host in a while, so if you want to poke at it while it's running we can probably arrange something if timezones work out, Matrix |
The pattern seems to have changed on that machine to something more healthy. I think we need a larger view of how this part of CUPS works.
|
Hi, this issue appears in cupsd randomly and it does not depend on subscriptions - I have seen it in several symptoms - removing job files, removing temporary printers, expiring subscriptions - the same ground is a variable which is compared with current_time is always lower than current_time, which causes cupsd doing the process every time when cupsdDoSelect() finishes. I haven't been able to reproduce it in stable way, so I wasn't able to deliver a fix yet. |
I've filed an issue to track it #604 |
I believe that I found the culprit: #604 (comment) |
Fixes NixOS/nixpkgs#195090.
NixOS systems with Avahi enabled would previously spam the journal with
this log message once a second: this hides that spam behind the log level.