Remove legacy building.Locked and building.BuildComplete from Gate. #15676
Conversation
|
Re (lack of) update rules: we have a few traits left to do, with a lot of that work already sitting open in parallel PRs. Most of the rule changes also span multiple levels of inheritance, so i'm not sure we can even usefully show a list of actors to change. If we don't have any better ideas I think our best option is to make a general note about this on https://github.com/OpenRA/OpenRAModSDK/wiki/Update-notes:-release-20180923-to-next |
| @@ -34,7 +34,7 @@ public class GateInfo : PausableConditionalTraitInfo, ITemporaryBlockerInfo, IBl | |||
| } | |||
|
|
|||
| public class Gate : PausableConditionalTrait<GateInfo>, ITick, ITemporaryBlocker, IBlocksProjectiles, | |||
| INotifyAddedToWorld, INotifyRemovedFromWorld, INotifyBlockingMove, ISync | |||
There was a problem hiding this comment.
There is a value with [Sync] (Position), why remove ISync? Tbh this doesn't look related so i guess this was a mistake.
There was a problem hiding this comment.
ConditionalTrait already implements ISync, so we can remove it here.
pchote
force-pushed
the
remove-gate-legacy-building-code
branch
from
7ee2e87
to
0b41cd9
Compare
|
Renamed |
Another step towards eliminating these legacy code warts.