-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose common actor Inits in the map editor. #15881
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, just two things I'd prefer to see changed/added (if not in this PR, then at least in a follow-up, but before a playtest):
Adding fixup label for the order changes, feel free to reject it if there are technical reasons why this can't be done easily. |
c50af7f
to
f4ae87b
Compare
Done, and added plumbing that allows this to be overridden from yaml.
The preview rendering assumes that the preview never moves, so this is easier said than done. I don't think this is likely to be fixed anytime soon. I've also added a new commit that fixes the dialog position overlapping the actor at larger zooms. |
This PR expands on #15551 by adding plumbing for trait-defined actor properties in the editor, and wiring up actor health, facing, turret facing and stance:
Fixes #15849.
Fixes #10818.