Merge pull request #2617 from tupaschoal/unify-scripts

translation_check: Report repeated and unexpected keys
OpenRCT2 · Apr 28, 2023 · 0d732cb · 0d732cb
2 parents c514494 + d94f57b
commit 0d732cb
Show file tree

Hide file tree

Showing 14 changed files with 7 additions and 639 deletions.
diff --git a/.github/workflows/translation_check.py b/.github/workflows/translation_check.py
@@ -43,7 +43,7 @@
                   'STR_6360']
 
 languages = []
-
+STR_NUMBER_RE = re.compile("STR_\d+")
 
 def get_arg_parser():
     """ Command line arguments """
@@ -105,8 +105,13 @@ def file_to_dict(filename):
             key = split[0].strip()
             if key in SPECIAL_KEYS:
                 key = previous_group_name + key
+            elif not STR_NUMBER_RE.match(key):
+                print(f'[{os.path.basename(filename)}]: {key} does not match STR_XXXX pattern')
             value = ':'.join(split[1:]).strip()
-            translations[key] = value
+            if key in translations:
+                print(f'[{os.path.basename(filename)}]: {key} is repeated')
+            else:
+                translations[key] = value
 
     return translations
 

diff --git a/appveyor.yml b/appveyor.yml
diff --git a/check.ps1 b/check.ps1
diff --git a/langcheck/Extensions/StringReaderExtensions.cs b/langcheck/Extensions/StringReaderExtensions.cs
diff --git a/langcheck/IErrorLogger.cs b/langcheck/IErrorLogger.cs
diff --git a/langcheck/LanguageEntry.cs b/langcheck/LanguageEntry.cs
diff --git a/langcheck/LanguageEntryType.cs b/langcheck/LanguageEntryType.cs
diff --git a/langcheck/LanguagePack.cs b/langcheck/LanguagePack.cs