Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checker script includes legacy strings? #2069

Closed
Wuzzy2 opened this issue Dec 4, 2020 · 3 comments
Closed

Checker script includes legacy strings? #2069

Wuzzy2 opened this issue Dec 4, 2020 · 3 comments
Labels

Comments

@Wuzzy2
Copy link
Contributor

Wuzzy2 commented Dec 4, 2020

I just noticed the checker script (.github/workflows/translation_check.py) complains about missing German strings for TTPIRF02-TTPIRF08, TTRFWD01-TTRFWD08, TTRFGL01-TTRFGL03, AACW33 and ACWWF32.
But if I remember correctly, those strings were recently moved to the objects repo, so they should no longer be relevant, right? I might be wrong, however.

If I am correct, the checker script needs to ignore those strings.

@Gymnasiast
Copy link
Member

Some object's translations have indeed been moved (e.g. TTRFTL02), but the ones you mentioned have not yet been moved to the objects repo, and thus still need to be in the translation files.

@Wuzzy2
Copy link
Contributor Author

Wuzzy2 commented Dec 4, 2020

I assume this implies it is planned to move these strings to the objects repo eventually. Right?

@Gymnasiast
Copy link
Member

In some form: yes. They represent objects that are common enough to warrant translation and/or fixes, but are not made official. They will be among the first to be converted to JSON objects once our object downloader can download them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants