Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

it-IT: Apply #2511, #2520, #2527, #2535, #2550, #2551, #2562, #2563, … #2672

Merged
merged 3 commits into from
Aug 29, 2023
Merged

it-IT: Apply #2511, #2520, #2527, #2535, #2550, #2551, #2562, #2563, … #2672

merged 3 commits into from
Aug 29, 2023

Conversation

fniutta
Copy link
Contributor

@fniutta fniutta commented Aug 20, 2023

@fniutta
it-IT: Apply #2511, #2520, #2527, #2535, #2550, #2551. #2562, #2563, #…
9e659dd 
…2572, #2578, #2594, #2602, #2609, #2620, #2625, #2631, #2641, #2650, #2658, #2659 + changed all the apostrophes to match the guidelines + resolved duplicate on String 5836
@github-actions
Copy link

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
it-IT 23 (-40) 19 (+18) 334 (-5)

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
ar-EG 71 2 1956
ca-ES 0 1 117
cs-CZ 380 0 246
da-DK 119 1 484
de-DE 0 1 352
en-US 3376 0 390
eo-ZZ 0 1 89
es-ES 0 1 304
fi-FI 153 1 109
fr-CA 3959 0 0
fr-FR 0 1 160
hu-HU 158 1 114
ja-JP 296 1 608
ko-KR 0 1 194
nb-NO 306 0 2165
nl-NL 0 13 451
pl-PL 138 1 380
pt-BR 0 1 146
ru-RU 1302 0 111
sv-SE 160 1 341
tr-TR 359 1 395
vi-VN 218 3 3260
zh-CN 0 1 82
zh-TW 113 0 332

@fniutta
Copy link
Contributor Author

fniutta commented Aug 21, 2023

I did a really big mistake on the apostrophes: I changed also the ones the were not part of the translation. I have to correct it.

@github-actions
Copy link

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
it-IT 5 (-58) 1 343 (+4)

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
ar-EG 71 2 1956
ca-ES 0 1 117
cs-CZ 380 0 246
da-DK 119 1 484
de-DE 0 1 352
en-US 3376 0 390
eo-ZZ 0 1 89
es-ES 0 1 304
fi-FI 153 1 109
fr-CA 3959 0 0
fr-FR 0 1 160
hu-HU 158 1 114
ja-JP 296 1 608
ko-KR 0 1 194
nb-NO 306 0 2165
nl-NL 0 13 451
pl-PL 138 1 380
pt-BR 0 1 146
ru-RU 1302 0 111
sv-SE 160 1 341
tr-TR 359 1 395
vi-VN 218 3 3260
zh-CN 0 1 82
zh-TW 113 0 332

tupaschoal
tupaschoal reviewed Aug 27, 2023
View reviewed changes
Copy link
Member

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mentioned having done #2550, but their strings STR_6540 and STR_6541 are still missing.

data/language/it-IT.txt Outdated Show resolved Hide resolved
data/language/it-IT.txt Outdated Show resolved Hide resolved
@fniutta @tupaschoal
Committed @tupaschoal's suggestions and added missing string for #2550
1ab5eeb 
Co-authored-by: Tulio Leao <tupaschoal@gmail.com>
@github-actions
Copy link

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
it-IT 3 (-60) 1 344 (+5)

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exits in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)
ar-EG 71 2 1956
ca-ES 0 1 117
cs-CZ 380 0 246
da-DK 119 1 484
de-DE 0 1 352
en-US 3376 0 390
eo-ZZ 0 1 89
es-ES 0 1 304
fi-FI 153 1 109
fr-CA 3959 0 0
fr-FR 0 1 160
hu-HU 158 1 114
ja-JP 296 1 608
ko-KR 0 1 194
nb-NO 306 0 2165
nl-NL 0 13 451
pl-PL 138 1 380
pt-BR 0 1 146
ru-RU 1302 0 111
sv-SE 160 1 341
tr-TR 359 1 395
vi-VN 218 3 3260
zh-CN 0 1 82
zh-TW 113 0 332

@tupaschoal tupaschoal merged commit 2262f58 into OpenRCT2:master Aug 29, 2023
@tupaschoal
Copy link
Member

Thanks for making it-IT up to date @fniutta !

According to the checker script, now there is only one string repeated and a scenario missing translation:

2023-08-29T07:17:27.5423069Z [it-IT.txt]: STR_5836 is repeated

2023-08-29T07:17:28.0746254Z [it-IT] Missing translation: <Tycoon Park>STR_SCNR
2023-08-29T07:17:28.0746454Z [it-IT] Missing translation: <Tycoon Park>STR_PARK
2023-08-29T07:17:28.0746823Z [it-IT] Missing translation: <Tycoon Park>STR_DTLS

@fniutta
Copy link
Contributor Author

fniutta commented Aug 30, 2023 •
edited
Loading

2023-08-29T07:17:27.5423069Z [it-IT.txt]: STR_5836 is repeated

It says that the STR_5836 is repeated, but i removed a duplicate creating this pull request and in the updated it-IT.txt i cannot find any duplicate. Am I doing something wrong?

@tupaschoal
Copy link
Member

It says that the STR_5836 is repeated, but i removed a duplicate creating this pull request and in the updated it-IT.txt i cannot find any duplicate. Am I doing something wrong?

I don't see it duplicated either, dunno why the CI is reporting it. So all that is left is the translation of the Tycoon park strings for IT to be up-to-date, it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tupaschoal tupaschoal tupaschoal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fniutta @tupaschoal