Create deb and rpm automatically #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just realized it should be packaged without being self-contained. |
|
When is the job supposed to run? It isn't part of the commit or tag actions. |
|
It runs when you push a tag that starts with v, just like the current release action is set up. |
I am just wondering, why not create the package every build? |
|
@samuel-w Notifying you again in case you missed the last message |
Margen67
reviewed
Dec 14, 2024
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
| - name: Setup .NET Core SDK | ||
| uses: actions/setup-dotnet@v3 |
There was a problem hiding this comment.
Suggested change
| uses: actions/setup-dotnet@v3 | |
| uses: actions/setup-dotnet@v4 |
Margen67
reviewed
Dec 14, 2024
| src/openlauncher/bin/Release/net7.0/${{ matrix.rid }}/publish/openlauncher.exe | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 |
There was a problem hiding this comment.
Suggested change
| uses: actions/checkout@v3 | |
| uses: actions/checkout@v4 |
Margen67
reviewed
Dec 14, 2024
| @@ -17,9 +19,9 @@ jobs: | |||
| - name: Checkout | |||
| uses: actions/checkout@v3 | |||
| - name: Setup .NET Core SDK | |||
| uses: actions/setup-dotnet@v1 | |||
| uses: actions/setup-dotnet@v3 | |||
There was a problem hiding this comment.
Suggested change
| uses: actions/setup-dotnet@v3 | |
| uses: actions/setup-dotnet@v4 |
Margen67
reviewed
Dec 14, 2024
| path: src/openlauncher/bin/Release/net7.0/${{ matrix.rid }}/publish/**/* | ||
| - name: Create release | ||
| uses: softprops/action-gh-release@v1 | ||
| path: src/openlauncher/bin/Release/net${{ env.dotnet-version }}/${{ matrix.rid }}/publish/**/* |
There was a problem hiding this comment.
Suggested change
| path: src/openlauncher/bin/Release/net${{ env.dotnet-version }}/${{ matrix.rid }}/publish/**/* | |
| path: src/openlauncher/bin/Release/net${{ env.dotnet-version }}/${{ matrix.rid }}/publish/**/* | |
| if-no-files-found: error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed the test (which can get rate limited somehow even though it's on GitHub's servers, but shouldn't happen to users unless they spam-click the buttons) and bumped action versions
https://github.com/samuel-w/OpenLauncher/releases/tag/v0.3.2
Closes #24