Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for macOS #34

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

MichaelJBerk
Copy link

This PR adds support for OpenLauncher on macOS. Currently the launcher builds and runs on macOS, but can't download new releases or launch the game.

  • OpenLauncher now uses the correct binary name on macOS so that it can launch the executable properly.
  • On all platforms, OpenLauncher currently uses ZipFile.ExtractToDirectory to extract the release once it's been downloaded. However, this method will not preserve file aliases on macOS, and since OpenRCT2.app contains several of them, the extracted application won't launch. To fix this, this PR calls/usr/bin/ditto in a subprocess to extract the .zip, which will preserve the files properly.
  • Since OpenLoco isn't currently supported on macOS, it doesn't appear in the launcher.
  • .gitignore is updated to ignore .ds_store and other hidden files that macOS likes to make

@IntelOrca
Copy link
Collaborator

Currently the CI does not build or publish a macOS version, are you able to add this? Without it, no macOS version will be released.

Add build scripts for macOS
Added macOS App Icon
@MichaelJBerk
Copy link
Author

I added a macOS build to the CI action, though it needs to use scripts to build/package it, since the process is a bit more complicated for macOS (it needs to build both x64 and arm64 versions, combine them, and then build the proper .app structure for them). The action doesn't sign and notarize the app, since I'm not entirely sure of the best way to handle that for CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants