Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let it snow2 #12922

Merged
merged 5 commits into from
Sep 15, 2020
Merged

Let it snow2 #12922

merged 5 commits into from
Sep 15, 2020

Conversation

Gymnasiast
Copy link
Member

This is a rebased version of #10754.

I have taken out the weather transitions, as they led to it snowing in July. That bit needs a rethink. In the meantime, though, people can now use the "Force Weather" feature to set their park to use snow.

@AaronVanGeffen
Copy link
Member

Sounds like a good compromise. Perhaps we could introduce colder climates in the new save format.

@AaronVanGeffen AaronVanGeffen added changelog This issue/PR deserves a changelog entry. network version Network version needs updating - double check before merging! labels Sep 13, 2020
@Gymnasiast
Copy link
Member Author

Either that or making sure snow can only happen in March, April, September, October (cold climate) or March, October (cool and wet).

@Gymnasiast Gymnasiast linked an issue Sep 13, 2020 that may be closed by this pull request
@Gymnasiast Gymnasiast mentioned this pull request Sep 13, 2020
@@ -5,6 +5,7 @@
- Feature: [#12712] Add TCP / socket plugin APIs.
- Feature: [#12840] Add Park.entranceFee to the plugin API.
- Feature: [#12886] Make all scenery placement and remove actions available to the plugin API.
- Feature: [#12922] Add snow, heavy snow and blizzard to weather types.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add #2350 and #10754

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just mentioning #2350 should do.

@brettpenzer123
Copy link
Contributor

Glad to see it's been added sadly I don't have enough time to work on my own projects and open-source ones as well. I did try to reimplement it as much as possible from my first initial implementation way back. I'm also not involved in the project as much as I'd like to be to which come to a lot of discussion about certain types of weather. Hope someone makes good use of it and good luck to those that carry this on. 👍

My city is going back into a local lockdown so this should be fun 🗡️

Gymnasiast and others added 2 commits September 14, 2020 21:57
Co-authored-by: Brett Penzer <brettpenzer123@live.co.uk>
Co-authored-by: Michael Steenbeek <m.o.steenbeek@gmail.com>
@Gymnasiast Gymnasiast merged commit 3acbb92 into OpenRCT2:develop Sep 15, 2020
@Gymnasiast Gymnasiast deleted the LetItSnow2 branch September 15, 2020 16:11
@Gymnasiast Gymnasiast modified the milestone: v0.3.1 Sep 15, 2020
@Gymnasiast
Copy link
Member Author

Glad to see it's been added sadly I don't have enough time to work on my own projects and open-source ones as well. I did try to reimplement it as much as possible from my first initial implementation way back. I'm also not involved in the project as much as I'd like to be to which come to a lot of discussion about certain types of weather. Hope someone makes good use of it and good luck to those that carry this on. +1

Thanks, and I completely understand. By all means, make sure your own projects (which pay the bills) are OK first, and don't feel too bad about yourself if there is no time or energy left for voluntary projects like this. They're voluntary, after all.

tupaschoal added a commit that referenced this pull request Sep 27, 2020
- Feature: [#10807] Add 2x and 4x zoom levels (currently limited to OpenGL).
- Feature: [#12703] Add scenario plugin APIs.
- Feature: [#12708] Add plugin-accessible names to all game actions.
- Feature: [#12712] Add TCP / socket plugin APIs.
- Feature: [#12840] Add Park.entranceFee to the plugin API.
- Feature: [#12884] Add BaseTileElement.occupiedQuadrants to the plugin API.
- Feature: [#12885] Add SmallSceneryElement.quadrant to the plugin API.
- Feature: [#12886] Make all scenery placement and remove actions available to the plugin API.
- Feature: [#2350, #12922] Add snow, heavy snow and blizzard to weather types.
- Fix: [#400] Unable to place some saved tracks flush to the ground (original bug).
- Fix: [#5753] Entertainers make themselves happy instead of the guests.
- Fix: [#7037] Unable to save tracks starting with a sloped turn or helix.
- Fix: [#12691] Ride graph tooltip incorrectly used count instead of number string.
- Fix: [#12694] Crash when switching ride types with construction window open.
- Fix: [#12701] Silent NSIS setup flag /S isn't silent, upgrade pop-up appears anyway.
- Fix: [#12737] Space Rings draw the same vehicle 4 times.
- Fix: [#12756] Scenario Editor crashing the game on macOS.
- Fix: [#12764] Rides don't start aged anymore.
- Fix: [#12818] Ride price not ignored in free-rides parks.
- Fix: [#12820] Title menu buttons not invalidating properly
- Fix: [#12845] Deleting ride with active ad campaign creates incorrect notification.
- Fix: [#12857] Incorrect Peep thoughts in imported RCT1 parks.
- Fix: [#12881] Guests' favourite rides are not listed in the guest window.
- Fix: [#12910] Plugin API: getRide sometimes returns null for valid ride IDs.
- Fix: [#12912] Plugin: selectedCell of CustomListView is being ignored on creation.
- Fix: [#12918] Cannot place vanilla TD6 tracks of the Hypercoaster, Monster Trucks, Classic Mini Roller Coaster, Spinning Wild Mouse and Hyper-Twister types.
- Fix: Incomplete loop collision box allowed overlapping track (original bug).
- Improved: [#12806] Add Esperanto diacritics to the sprite font.
- Improved: [#12837] Arabic text is now drawn and shaped correctly on Windows.
- Improved: [#12890] Add stroke to lowercase 'L' to differentiate from capital 'I'.
- Technical: [#12749] The required version of macOS has been lowered to 10.13 (High Sierra).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog This issue/PR deserves a changelog entry. network version Network version needs updating - double check before merging!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New precipitation: Snow
3 participants