Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #12793: Excitement/Intensity/Nausea ratings to Ride List view with sorting #16655

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

Piperapk
Copy link
Contributor

@Piperapk Piperapk commented Feb 13, 2022

This PR references issue #12793. Adding a simple overview for Excitement/Intensity/Nausea in the Ride List.

Excitement:
excitement

Intensity:
Intensity

Nausea:
Nausea

Copy link
Member

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Piperapk and welcome to the OpenRCT2 project!

Can you add a few gifs and images to your original post showing how these windows work now?
Thanks :)

@Piperapk
Copy link
Contributor Author

Piperapk commented Feb 14, 2022

Hi @tupaschoal, glad to be here :) I've updated the post. Let me know if you need more screens or anything else.

src/openrct2/localisation/StringIds.h Outdated Show resolved Hide resolved
src/openrct2-ui/windows/RideList.cpp Outdated Show resolved Hide resolved
src/openrct2-ui/windows/RideList.cpp Outdated Show resolved Hide resolved
data/language/en-GB.txt Show resolved Hide resolved
data/language/en-GB.txt Show resolved Hide resolved
Copy link
Member

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Piperapk can you fix the formatting issue pointed out by one of the CI jobs?

Also make sure you mark the comments you tended to as "resolved", so the main conversation page on the PR has only the pending stuff :)

@Piperapk
Copy link
Contributor Author

Piperapk commented Mar 9, 2022

@Piperapk can you fix the formatting issue pointed out by one of the CI jobs?

Also make sure you mark the comments you tended to as "resolved", so the main conversation page on the PR has only the pending stuff :)

Thank you for walking me through this. I fixed the clang-format and marked all relevant comments as resolved :)

Copy link
Member

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok now @Piperapk, thanks for tending to it. Can you edit distributiion/changelog.txt with something like

- Feature: [#12793] Add Excitement/Intensity/Nausea ratings to Ride List view with sorting.

Note that the changes there are sorted by type and number, so do keep the sorting!

@Piperapk
Copy link
Contributor Author

Great, thanks @tupaschoal. All done now.

@tupaschoal tupaschoal changed the title Add #12793 Excitement/Intensity/Nausea ratings to Ride List view with sorting Close #12793: Excitement/Intensity/Nausea ratings to Ride List view with sorting Mar 10, 2022
@tupaschoal tupaschoal enabled auto-merge (squash) March 10, 2022 23:41
@tupaschoal tupaschoal disabled auto-merge March 10, 2022 23:41
@tupaschoal tupaschoal force-pushed the ride-list-additions branch from 4c2ef20 to f66c005 Compare March 11, 2022 10:56
@tupaschoal tupaschoal force-pushed the ride-list-additions branch from f66c005 to 103d44b Compare March 11, 2022 10:57
@tupaschoal tupaschoal enabled auto-merge (squash) March 11, 2022 10:59
@tupaschoal tupaschoal merged commit eb423a7 into OpenRCT2:develop Mar 11, 2022
@tupaschoal tupaschoal added this to the v0.4.0 milestone Mar 11, 2022
@tupaschoal
Copy link
Member

@Piperapk I ended up going to your repo, squashing all 5 commits and reducing the size of the commit message to comply with our 72 character limit.

@Piperapk
Copy link
Contributor Author

Thanks, @tupaschoal. Noted for the future and sorry for the commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants