-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close #12793: Excitement/Intensity/Nausea ratings to Ride List view with sorting #16655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Piperapk and welcome to the OpenRCT2 project!
Can you add a few gifs and images to your original post showing how these windows work now?
Thanks :)
Hi @tupaschoal, glad to be here :) I've updated the post. Let me know if you need more screens or anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Piperapk can you fix the formatting issue pointed out by one of the CI jobs?
Also make sure you mark the comments you tended to as "resolved", so the main conversation page on the PR has only the pending stuff :)
Thank you for walking me through this. I fixed the clang-format and marked all relevant comments as resolved :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok now @Piperapk, thanks for tending to it. Can you edit distributiion/changelog.txt
with something like
- Feature: [#12793] Add Excitement/Intensity/Nausea ratings to Ride List view with sorting.
Note that the changes there are sorted by type and number, so do keep the sorting!
Great, thanks @tupaschoal. All done now. |
4c2ef20
to
f66c005
Compare
Now tracks Excitement/Intensity/Nausea
f66c005
to
103d44b
Compare
@Piperapk I ended up going to your repo, squashing all 5 commits and reducing the size of the commit message to comply with our 72 character limit. |
Thanks, @tupaschoal. Noted for the future and sorry for the commit message. |
This PR references issue #12793. Adding a simple overview for Excitement/Intensity/Nausea in the Ride List.
Excitement:
Intensity:
Nausea: