Add new audio objects for loading sounds #17188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gymnasiast
reviewed
May 10, 2022
|
I don’t have a lot to remark about the design, it seems fine to me. Perhaps Duncan can say more about that. I do think it might be worth splitting off (some of?) the object refactors so everything can be tested properly. |
frutiemax
reviewed
May 14, 2022
| private: | ||
| struct Entry | ||
| { | ||
| OpenRCT2::Audio::IAudioSource* Source{}; |
There was a problem hiding this comment.
Why isn't this a smart pointer.
There was a problem hiding this comment.
Sources are stored as smart pointers, but on the mixer.
|
There is far too much happening in this PR to be able to review it properly. If it all works i've got nothing much to say about it the audio code as you know is not the prettiest to use. |
duncanspumpkin
approved these changes
May 22, 2022
Co-authored-by: Michael Steenbeek <m.o.steenbeek@gmail.com>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All references to CSS are now moved to an object file which is loaded at the start of the game. The audio object type is a new kind of object which is not saved to park files.
New audio objects are available in this PR:
OpenRCT2/objects#185
They include:
rct2.audio.base - Base audio for OpenRCT2, includes all sound effects and crowd ambience.
rct2.audio.title - The RCT2 title music.
rct2.audio.circus - The "ride music" that is played by the circus ride.
rct1.audio.title - The RCT1 title music.
The audio code is a bit of a mess. It went through a few refactors and still remains unfinished. So at some point I need to go back and clean it up.