This repository has been archived by the owner on Oct 5, 2024. It is now read-only.
ES6 the Site #41
Open
ES6 the Site #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
say25
commented
Apr 15, 2023
| @@ -23,9 +23,6 @@ iframe { | |||
| margin: 0 auto; | |||
| display: block; | |||
| border: 1px solid #ccc; | |||
| seamless; | |||
| frameborder: 0; | |||
| scrolling: no; | |||
There was a problem hiding this comment.
According to https://caniuse.com/ all these attributes are not supported by any browser any more
| var dm = decimals + 1 || 3; | ||
| var sizes = ['bytes', 'KB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB']; | ||
| var i = Math.floor(Math.log(bytes) / Math.log(k)); | ||
| // https://stackoverflow.com/questions/15900485/correct-way-to-convert-size-in-bytes-to-kb-mb-gb-in-javascript |
| if (navigator.platform.indexOf('Win') >= 0){ | ||
| if (navigator.userAgent.indexOf("WOW64") === -1 && navigator.userAgent.indexOf("Win64") === -1 ){ | ||
| function getPlatform() { | ||
| const { platform, userAgent } = navigator; |
Broxzier
reviewed
Apr 17, 2023
| const setupPageControl = (container, pageType) => { | ||
| const buttons = document.querySelectorAll(container + ' .btn-' + pageType); | ||
| for (let i = 0; i < buttons.length; i++) { | ||
| buttons[i].addEventListener('click', () => { | ||
| if (!this.classList.contains('active')) { |
There was a problem hiding this comment.
Have you verified that this still works? IIRC, this does not exist in arrow functions, but it does in normal functions like how it was before. I don't really see a reason for changing all functions into arrow functions in the first place.
There was a problem hiding this comment.
Reverted the change, I guess there isn't a strong reason to really use arrow functions in most places
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.