Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gui class contain all its control elements #42

Closed
wants to merge 0 commits into from

Conversation

ceanwang
Copy link
Contributor

@ceanwang ceanwang commented Jan 6, 2025

These changes make the gui easy to be started by 3rd party code.

  1. Moved the control elements initialization code from the bottom of the code into the init function
  2. Changed all gui. into self. accordingly, like gui.Window.thread_mpi to self.Window.thread_mpi
  3. Changed all variables as self. variable, like nt_entry to self.nt_entry

@OlivierWienholtz
Copy link
Contributor

Hello Ceanwang
Thank for your contributions.

Can you please rebase the commits into 1 ?
This simplifies the commits...

Thanks !

@ceanwang
Copy link
Contributor Author

ceanwang commented Jan 9, 2025

Sorry, I am not familiar with github. Don't know what am doing. I am using Windows 10.
What should I do? Maybe re-create a clean pull request?

@OlivierWienholtz
Copy link
Contributor

Dear CeanWang
Indeed we can help you to get into the Workflow.
I just saw that you use your main branch to perform the changes.
In git, main branch remains clean & changes are done in development branches.

Here are some pages about Workflow & Git:
Our How to contribute :
https://github.com/OpenRadioss/Tools/blob/main/Contributing.md
At GitHub Some documentations :
https://docs.github.com/en/get-started/using-github/github-flow

you can also contact communitymanager@openradioss.org
We can help you on this.

Best Regards,
Olivier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants