front: update background color of the Manchette to match the mockup #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: theocrsb <theo_crosbie@yahoo.fr>
theocrsb
force-pushed
the
tce/manchette/update-bg-color
branch
from
418437b to
e923840
Compare
SharglutDev
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Lgtm and tested.
But we have another (unrelated) bug that we never spotted. You could maybe fix it in another PR before freeze to match the mockup :
right now :
The manchette should add at the bottom of the space time, x graduations not included and this zone shouldn't have a white bg.
Okay I created a ticket I will send another PR to fix this problem: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mockup:
