Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: doc: preamble.fr.md spelling ... #229

Merged
merged 1 commit into from
Sep 2, 2024
Merged

fix: doc: preamble.fr.md spelling ... #229

merged 1 commit into from
Sep 2, 2024

Conversation

SergeCroise
Copy link
Contributor

  • open-source
  • pour discuter
  • repose sur

@SergeCroise
fix: doc: preamble.fr.md spelling ...
757091d 
- open-source
- pour discuter
- repose sur
@SergeCroise
Copy link
Contributor Author

@flomonster , please review!

flomonster
flomonster approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flomonster
Copy link
Contributor

@flomonster , please review!

Thanks for all your contributions. You should be able to add a reviewer to your PR. This notify the person directly.

@flomonster flomonster merged commit 64d455c into OpenRailAssociation:master Sep 2, 2024
2 checks passed
@SergeCroise SergeCroise deleted the patch-4 branch September 2, 2024 11:14
@SergeCroise
Copy link
Contributor Author

SergeCroise commented Sep 2, 2024 •
edited
Loading

@flomonster , please review!

Thanks for all your contributions. You should be able to add a reviewer to your PR. This notify the person directly.

unfortunately, I do not know how...
maybe because I have only read access to the osrd-website repository:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/requesting-a-pull-request-review
In this project (netzgrafik) the reviewer is assigned automatically, without the need to get something else than read access, e.g.:
SchweizerischeBundesbahnen/netzgrafik-editor-frontend#276
I prefer to have only read access to prevent accidents...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomonster flomonster flomonster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergeCroise @flomonster