core: add warning on route ending on non route delimiting signal in block generation #10426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10426 +/- ##
==========================================
- Coverage 81.78% 81.77% -0.01%
==========================================
Files 1073 1073
Lines 106577 106578 +1
Branches 731 731
==========================================
- Hits 87162 87158 -4
- Misses 19376 19381 +5
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
the
area:ci
Khoyo
force-pushed
the
ali/add-warning-route-ending-non-nf-signal-in-core-block-gen
branch
3 times, most recently
from
234343b to
5e8b34f
Compare
github-actions
bot
removed
the
area:ci
Khoyo
approved these changes
Jan 17, 2025
eckter
reviewed
Jan 17, 2025
core/kt-osrd-signaling/src/main/kotlin/fr/sncf/osrd/signaling/impl/BlockBuilder.kt
Outdated
Show resolved
Hide resolved
eckter
approved these changes
Jan 20, 2025
Synar
force-pushed
the
ali/add-warning-route-ending-non-nf-signal-in-core-block-gen
branch
from
e819260 to
b7dba3c
Compare
…lock generation Signed-off-by: Alice Khoudli <alice.khoudli@polytechnique.org>
Synar
force-pushed
the
ali/add-warning-route-ending-non-nf-signal-in-core-block-gen
branch
from
b7dba3c to
2ba1ecb
Compare
Synar
deleted the
ali/add-warning-route-ending-non-nf-signal-in-core-block-gen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4606
We only check that route ends on Nf signals (or more generally route delimiting signal), not whether they start on it