Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: display only trains around stdcm result #10432

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

front: display only trains around stdcm result #10432

wants to merge 3 commits into from

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Jan 17, 2025 •
edited
Loading

closes #9131

@emersion emersion self-requested a review January 17, 2025 15:54
@clarani
front: separate useLazyProjectTrains and useLazyLoadTrains hooks
c7d99d2 
Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani
front: display only trains around the stdcm train on the GET in debug…
bcb1ee0 
… mode

Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani
front: remove pathTrackRanges from stdcmResults props
c586622 
Signed-off-by: Clara Ni <clara.ni@outlook.fr>
@clarani clarani force-pushed the cni/9131-display-only-trains-around-stdcm-result branch from 2b20c62 to c586622 Compare January 17, 2025 16:10
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 17, 2025
@clarani clarani marked this pull request as ready for review January 17, 2025 16:16
@clarani clarani requested a review from a team as a code owner January 17, 2025 16:16
@bloussou
Copy link
Contributor

changed

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.77%. Comparing base (bcbc767) to head (c586622).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #10432      +/-   ##
==========================================
- Coverage   81.78%   81.77%   -0.01%     
==========================================
  Files        1073     1073              
  Lines      106493   106554      +61     
  Branches      727      727              
==========================================
+ Hits        87099    87139      +40     
- Misses      19355    19376      +21     
  Partials       39       39
Flag Coverage Δ
editoast 74.15% <ø> (-0.07%) ⬇️
front 89.37% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersion emersion Awaiting requested review from emersion

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stdcm: only display trains that surround the result in the GET
3 participants
@clarani @bloussou @codecov-commenter