Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: cleanup error types and fix some causes #5331

Merged
merged 1 commit into from
Oct 17, 2023
Merged

core: cleanup error types and fix some causes #5331

merged 1 commit into from
Oct 17, 2023

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Oct 13, 2023

No description provided.

@eckter eckter requested a review from a team as a code owner October 13, 2023 09:09
Erashin
Erashin approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@Erashin Erashin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaaaaaayyy :evoli: :D

@codecov
Copy link

codecov bot commented Oct 13, 2023 •
edited
Loading

Codecov Report

Merging #5331 (453ffc5) into dev (d09c49e) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev    #5331   +/-   ##
=========================================
  Coverage     18.73%   18.73%           
  Complexity     2309     2309           
=========================================
  Files           849      849           
  Lines        103064   103045   -19     
  Branches       2397     2397           
=========================================
- Hits          19307    19304    -3     
+ Misses        82419    82403   -16     
  Partials       1338     1338
Flag Coverage Δ
core 78.77% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...a/fr/sncf/osrd/reporting/exceptions/ErrorType.java 100.00% <ø> (ø)
...a/fr/sncf/osrd/reporting/exceptions/OSRDError.java 28.30% <ø> (+2.66%) ⬆️
...tion/tracks/undirected/UndirectedInfraBuilder.java 85.05% <ø> (+1.59%) ⬆️

@eckter eckter enabled auto-merge October 17, 2023 15:05
@eckter eckter added this pull request to the merge queue Oct 17, 2023
Merged via the queue into dev with commit a6b9322 Oct 17, 2023
5 checks passed
@eckter eckter deleted the ech/cleanup-errors branch October 17, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Khoyo Khoyo Khoyo approved these changes

@Erashin Erashin Erashin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eckter @Khoyo @Erashin