-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: stdcm: stabilize running time computations #5386
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #5386 +/- ##
=========================================
Coverage 18.73% 18.73%
- Complexity 2309 2313 +4
=========================================
Files 849 849
Lines 102946 102954 +8
Branches 2398 2400 +2
=========================================
+ Hits 19282 19287 +5
- Misses 82325 82326 +1
- Partials 1339 1341 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
25446af
to
2be81be
Compare
We often need an epsilon-length step in positions, but the values in time deltas are much smaller than the position deltas, so we often have zeros there. The constraint has been moved to positions to avoid "empty" steps.
2be81be
to
6d8817e
Compare
core/envelope-sim/src/main/java/fr/sncf/osrd/envelope/part/EnvelopePart.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
core/src/main/java/fr/sncf/osrd/stdcm/graph/AllowanceManager.java
Outdated
Show resolved
Hide resolved
6d8817e
to
aa7735b
Compare
The changes have been made on the same branch to stabilize everything until the fuzzer is stable. This ensures that we don't have partial fixes (see #5362) and we don't create new bugs with the fixes.
It now seems stable, I've run 2500 tests on a real infra and the only errors reported were unrelated to running time computations (I'll open issues for those).
Changes include:
Fixes #5329
Fixes #5372