core: stdcm: stabilize running time computations #5386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #5386 +/- ##
=========================================
Coverage 18.73% 18.73%
- Complexity 2309 2313 +4
=========================================
Files 849 849
Lines 102946 102954 +8
Branches 2398 2400 +2
=========================================
+ Hits 19282 19287 +5
- Misses 82325 82326 +1
- Partials 1339 1341 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
eckter
force-pushed
the
ech/stdcm-bugfixes
branch
from
25446af
to
2be81be
Compare
We often need an epsilon-length step in positions, but the values in time deltas are much smaller than the position deltas, so we often have zeros there. The constraint has been moved to positions to avoid "empty" steps.
eckter
force-pushed
the
ech/stdcm-bugfixes
branch
from
2be81be
to
6d8817e
Compare
eckter
commented
Oct 19, 2023
core/envelope-sim/src/main/java/fr/sncf/osrd/envelope/part/EnvelopePart.java
Show resolved
Hide resolved
multun
reviewed
Oct 19, 2023
core/src/main/java/fr/sncf/osrd/stdcm/graph/AllowanceManager.java
Outdated
Show resolved
Hide resolved
eckter
force-pushed
the
ech/stdcm-bugfixes
branch
from
6d8817e
to
aa7735b
Compare
multun
approved these changes
Oct 19, 2023
Erashin
approved these changes
Oct 19, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes have been made on the same branch to stabilize everything until the fuzzer is stable. This ensures that we don't have partial fixes (see #5362) and we don't create new bugs with the fixes.
It now seems stable, I've run 2500 tests on a real infra and the only errors reported were unrelated to running time computations (I'll open issues for those).
Changes include:
Fixes #5329
Fixes #5372