Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: refacto signals settings on maps, removing signal's list concept #5472

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

nicolaswurtz
Copy link
Contributor

@nicolaswurtz nicolaswurtz commented Oct 26, 2023

This PR fixes:

It removes "signallist" logic that's today irrelevant: backend only sends one layer without signal's type anymore.
Too much filters existed before that prevented signals and their assets to display.

@nicolaswurtz nicolaswurtz requested a review from a team as a code owner October 26, 2023 11:10
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #5472 (e7737ff) into dev (74fc252) will increase coverage by 0.02%.
The diff coverage is 2.89%.

@@             Coverage Diff              @@
##                dev    #5472      +/-   ##
============================================
+ Coverage     18.80%   18.82%   +0.02%     
  Complexity     2320     2320              
============================================
  Files           860      859       -1     
  Lines        103596   103400     -196     
  Branches       2412     2410       -2     
============================================
- Hits          19479    19465      -14     
+ Misses        82769    82589     -180     
+ Partials       1348     1346       -2     
Flag Coverage Δ
front 7.14% <2.89%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...lications/editor/tools/pointEdition/components.tsx 0.00% <ø> (ø)
front/src/common/Map/Layers/types.ts 0.00% <ø> (ø)
front/src/reducers/index.ts 100.00% <ø> (ø)
front/src/reducers/map/index.ts 82.79% <100.00%> (-0.71%) ⬇️
front/src/reducers/map/selectors.ts 0.00% <ø> (ø)
front/src/common/Map/Layers/BufferStops.tsx 0.00% <0.00%> (ø)
front/src/common/Map/Layers/Detectors.tsx 0.00% <0.00%> (ø)
front/src/common/Map/Layers/geoSignalsLayers.ts 0.00% <0.00%> (ø)
front/src/common/Map/Layers/GeoJSONs.tsx 0.00% <0.00%> (ø)
front/src/common/Map/Layers/Signals.tsx 0.00% <0.00%> (ø)
... and 1 more

@nicolaswurtz nicolaswurtz force-pushed the nwz/refacto-signallist-switch branch 2 times, most recently from b8c4f28 to 2272264 Compare October 26, 2023 12:40
@nicolaswurtz nicolaswurtz added this pull request to the merge queue Oct 26, 2023
Merged via the queue into dev with commit 19a7720 Oct 26, 2023
5 checks passed
@nicolaswurtz nicolaswurtz deleted the nwz/refacto-signallist-switch branch October 26, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signal's masts & blue points not displayed on maps Signals are not displayed in the editor
2 participants