Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: add placeholder 0 in budget and allowances inputs #5514

Merged
merged 2 commits into from
Nov 7, 2023
Merged

front: add placeholder 0 in budget and allowances inputs #5514

merged 2 commits into from
Nov 7, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Oct 30, 2023 •
edited
Loading

closes #5548
closes #5477

  • created new types AllowanceValueForm in which value can be undefined
  • added placeholders in allowances inputs, as well as in budget inputs

image
image

@clarani clarani requested a review from a team as a code owner October 30, 2023 11:08
@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

Merging #5514 (cb4e0e4) into dev (f5c0e06) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #5514      +/-   ##
============================================
- Coverage     19.62%   19.61%   -0.02%     
  Complexity     2322     2322              
============================================
  Files           879      879              
  Lines        105479   105573      +94     
  Branches       2566     2566              
============================================
  Hits          20704    20704              
- Misses        83272    83366      +94     
  Partials       1503     1503
Flag Coverage Δ
front 8.37% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
front/src/common/BootstrapSNCF/InputGroupSNCF.tsx 0.00% <0.00%> (ø)
...omponents/ManageTrainSchedule/Allowances/consts.ts 0.00% <0.00%> (ø)
.../ManageTrainSchedule/Allowances/AllowancesList.tsx 0.00% <0.00%> (ø)
...dules/project/components/AddOrEditProjectModal.tsx 0.00% <0.00%> (ø)
...c/modules/study/components/AddOrEditStudyModal.tsx 0.00% <0.00%> (ø)
...ageTrainSchedule/Allowances/AllowancesListItem.tsx 0.00% <0.00%> (ø)
...eTrainSchedule/Allowances/AllowancesLinearView.tsx 0.00% <0.00%> (ø)
...mponents/ManageTrainSchedule/Allowances/helpers.ts 0.00% <0.00%> (ø)
...ents/ManageTrainSchedule/Allowances/Allowances.tsx 0.00% <0.00%> (ø)
...nageTrainSchedule/Allowances/AllowancesActions.tsx 0.00% <0.00%> (ø)
... and 2 more

@clarani clarani changed the title front: add placeholder 0 in number inputs front: add placeholder 0 in budget and allowances inputs Oct 31, 2023
@clarani clarani mentioned this pull request Oct 31, 2023
Closed
SharglutDev
SharglutDev reviewed Nov 2, 2023
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting this in all inputs where you are using undefined as default value

image

@clarani clarani force-pushed the cni-5221-placeholder-number-input branch 2 times, most recently from 58b2b04 to 6692c83 Compare November 6, 2023 07:19
@clarani clarani force-pushed the cni-5221-placeholder-number-input branch from 6692c83 to 22e093b Compare November 6, 2023 13:27
Akctarus
Akctarus reviewed Nov 7, 2023
View reviewed changes
front/public/locales/en/translation.json Outdated Show resolved Hide resolved
front/public/locales/fr/translation.json Outdated Show resolved Hide resolved
Akctarus
Akctarus approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clarani clarani force-pushed the cni-5221-placeholder-number-input branch from 22e093b to cb4e0e4 Compare November 7, 2023 15:10
@clarani
Copy link
Contributor Author

clarani commented Nov 7, 2023 •
edited
Loading

Viewed with Nicolas and Thibaut, we decided to simply remove the placeholders (instead of placeholders "choisissez..."

@clarani clarani added this pull request to the merge queue Nov 7, 2023
Merged via the queue into dev with commit 5bda1ac Nov 7, 2023
4 of 5 checks passed
@clarani clarani deleted the cni-5221-placeholder-number-input branch November 7, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaswurtz nicolaswurtz nicolaswurtz approved these changes

@anisometropie anisometropie anisometropie approved these changes

@Akctarus Akctarus Akctarus approved these changes

@SharglutDev SharglutDev SharglutDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: add placeholders to budget and allowances inputs Number format in budget field
5 participants
@clarani @nicolaswurtz @anisometropie @Akctarus @SharglutDev