Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front : fix margin card width #5590

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

RomainValls
Copy link
Contributor

closes #5565

@RomainValls RomainValls requested a review from a team as a code owner November 3, 2023 09:46
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (78906cb) 19.61% compared to head (366cb08) 19.61%.

Files Patch % Lines
.../src/applications/stdcm/components/RunningTime.tsx 0.00% 1 Missing ⚠️
...les/stdcmAllowances/components/StdcmAllowances.tsx 0.00% 1 Missing ⚠️
...onents/ManageTrainSchedule/Itinerary/Itinerary.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #5590   +/-   ##
=========================================
  Coverage     19.61%   19.61%           
  Complexity     2326     2326           
=========================================
  Files           886      886           
  Lines        105942   105942           
  Branches       2576     2576           
=========================================
  Hits          20785    20785           
  Misses        83648    83648           
  Partials       1509     1509           
Flag Coverage Δ
front 8.34% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomainValls RomainValls changed the title stdcm : fix margin card width front : fix margin card width Nov 3, 2023
Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 1 small comment.
Can you squash your commits and rebase ? Thanks ! :)

@RomainValls RomainValls force-pushed the rvs/front-fix-margin-card-width-in-stdcm branch from 69ebdb4 to 5bf1cdf Compare November 3, 2023 15:11
@RomainValls
Copy link
Contributor Author

C'est fait, merci !

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !! tested ✅

- remove-useless-padding-in-running-time

- Update front/src/modules/stdcmAllowances/components/STDCMAllowances.tsx

Co-authored-by: Yoh <durandyohan@zaclys.net>

- add margin bot to itinerary and runningtime
@RomainValls RomainValls force-pushed the rvs/front-fix-margin-card-width-in-stdcm branch from 5bf1cdf to 366cb08 Compare November 16, 2023 09:53
@RomainValls RomainValls added this pull request to the merge queue Nov 16, 2023
Merged via the queue into dev with commit d8a9f7a Nov 16, 2023
5 checks passed
@RomainValls RomainValls deleted the rvs/front-fix-margin-card-width-in-stdcm branch November 16, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Margin card has not the correct width in STDCM
3 participants