Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: fix operational-studies-routes #5646

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

younesschrifi
Copy link
Contributor

close #5630

@younesschrifi younesschrifi requested a review from a team as a code owner November 10, 2023 08:38
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We could add a test or two.

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #5646 (4f0ca39) into dev (24c2796) will increase coverage by 0.00%.
Report is 15 commits behind head on dev.
The diff coverage is 57.14%.

@@            Coverage Diff            @@
##                dev    #5646   +/-   ##
=========================================
  Coverage     19.61%   19.62%           
  Complexity     2322     2322           
=========================================
  Files           879      879           
  Lines        105591   105597    +6     
  Branches       2566     2566           
=========================================
+ Hits          20716    20720    +4     
- Misses        83372    83374    +2     
  Partials       1503     1503           
Flag Coverage Δ
editoast 67.98% <57.14%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
editoast/src/views/study.rs 94.31% <50.00%> (+0.13%) ⬆️
editoast/src/views/scenario.rs 96.42% <60.00%> (+0.17%) ⬆️

... and 2 files with indirect coverage changes

@younesschrifi younesschrifi force-pushed the yci/fix-operational-studies-routes branch from d4e215f to a5c736f Compare November 12, 2023 19:51
@younesschrifi younesschrifi force-pushed the yci/fix-operational-studies-routes branch from a5c736f to 4f0ca39 Compare November 12, 2023 20:06
@younesschrifi younesschrifi added this pull request to the merge queue Nov 13, 2023
Merged via the queue into dev with commit 7306be6 Nov 13, 2023
7 of 8 checks passed
@younesschrifi younesschrifi deleted the yci/fix-operational-studies-routes branch November 13, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

editoast: no nesting checks between projects, studies and scenarios
2 participants