Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: refactor main.rs db_pool #5695

Merged
merged 1 commit into from
Nov 16, 2023
Merged

editoast: refactor main.rs db_pool #5695

merged 1 commit into from
Nov 16, 2023

Conversation

anisometropie
Copy link
Contributor

@anisometropie anisometropie commented Nov 15, 2023 •
edited
Loading

closes #5703

@anisometropie anisometropie requested a review from a team as a code owner November 15, 2023 14:09
leovalais
leovalais requested changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

editoast/src/main.rs Outdated Show resolved Hide resolved
@anisometropie anisometropie force-pushed the vcs/refacto-run-db-pool branch 2 times, most recently from d4dedec to 64dc482 Compare November 16, 2023 10:36
leovalais
leovalais requested changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good!

editoast/src/main.rs Outdated Show resolved Hide resolved
@anisometropie anisometropie force-pushed the vcs/refacto-run-db-pool branch 2 times, most recently from ff80cbe to 560600c Compare November 16, 2023 11:28
@codecov Codecov
Copy link

codecov bot commented Nov 16, 2023 •
edited
Loading

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (735e9a4) 19.62% compared to head (016ffe8) 19.61%.
Report is 2 commits behind head on dev.

Files Patch % Lines
editoast/src/main.rs 14.28% 24 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #5695      +/-   ##
============================================
- Coverage     19.62%   19.61%   -0.02%     
  Complexity     2326     2326              
============================================
  Files           886      886              
  Lines        105946   105943       -3     
  Branches       2576     2576              
============================================
- Hits          20789    20776      -13     
- Misses        83648    83658      +10     
  Partials       1509     1509
Flag Coverage Δ
editoast 68.13% <14.28%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leovalais leovalais self-requested a review November 16, 2023 11:39
leovalais
leovalais reviewed Nov 16, 2023
View reviewed changes
editoast/src/main.rs Outdated Show resolved Hide resolved
@anisometropie anisometropie added this pull request to the merge queue Nov 16, 2023
Merged via the queue into dev with commit 6e7fc8d Nov 16, 2023
7 of 8 checks passed
@anisometropie anisometropie deleted the vcs/refacto-run-db-pool branch November 16, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leovalais leovalais leovalais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refacto main.rs db_pool
2 participants
@anisometropie @leovalais