Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix noData message in empty scenario #5780

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

RomainValls
Copy link
Contributor

closes #5561

@RomainValls RomainValls requested a review from a team as a code owner November 21, 2023 16:00
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4e8db62) 19.52% compared to head (db6bc45) 19.52%.
Report is 1 commits behind head on dev.

Files Patch % Lines
...ons/operationalStudies/views/SimulationResults.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #5780   +/-   ##
=========================================
  Coverage     19.52%   19.52%           
  Complexity     2327     2327           
=========================================
  Files           907      907           
  Lines        106974   106974           
  Branches       2590     2590           
=========================================
  Hits          20883    20883           
  Misses        84565    84565           
  Partials       1526     1526           
Flag Coverage Δ
front 8.41% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomainValls RomainValls self-assigned this Nov 21, 2023
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested
Maybe you can create a new translation for noData in "operationalStudies/scenario" since it is used there, instead of using the one from "simulation".

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@RomainValls RomainValls added this pull request to the merge queue Nov 23, 2023
Merged via the queue into dev with commit 12f2a16 Nov 23, 2023
7 checks passed
@RomainValls RomainValls deleted the rvs/front-fix-noData-msg-in-op-studies branch November 23, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"noData" displayed when scenario is empty, no matter the language
4 participants