Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix psl announcement first value #5939

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Conversation

Tguisnet
Copy link
Contributor

@Tguisnet Tguisnet commented Nov 30, 2023

Close #4466
Close #5940

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (69d6902) 25.74% compared to head (8a39fcc) 25.73%.

Files Patch % Lines
...tools/rangeEdition/speedSection/EditPSLSection.tsx 0.00% 50 Missing and 1 partial ⚠️
...lications/editor/tools/rangeEdition/components.tsx 0.00% 2 Missing ⚠️
...or/tools/rangeEdition/speedSection/PslSignCard.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5939      +/-   ##
============================================
- Coverage     25.74%   25.73%   -0.01%     
  Complexity     2117     2117              
============================================
  Files           926      926              
  Lines        122479   122524      +45     
  Branches       2665     2665              
============================================
+ Hits          31534    31536       +2     
- Misses        89372    89415      +43     
  Partials       1573     1573              
Flag Coverage Δ
core 79.01% <ø> (ø)
editoast 73.84% <ø> (ø)
front 8.43% <3.57%> (-0.01%) ⬇️
gateway 2.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tguisnet Tguisnet marked this pull request as ready for review December 1, 2023 09:30
@Tguisnet Tguisnet requested a review from a team as a code owner December 1, 2023 09:30
@SharglutDev SharglutDev self-requested a review December 1, 2023 12:01
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR ! Lgtm and tested and it works great.
Left some suggestions.

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm o//

@Tguisnet Tguisnet added this pull request to the merge queue Dec 5, 2023
Merged via the queue into dev with commit 968fba5 Dec 5, 2023
17 checks passed
@Tguisnet Tguisnet deleted the tgu/fix-psl-announcement branch December 5, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants