-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix psl announcement first value #5939
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #5939 +/- ##
============================================
- Coverage 25.74% 25.73% -0.01%
Complexity 2117 2117
============================================
Files 926 926
Lines 122479 122524 +45
Branches 2665 2665
============================================
+ Hits 31534 31536 +2
- Misses 89372 89415 +43
Partials 1573 1573
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR ! Lgtm and tested and it works great.
Left some suggestions.
front/src/applications/editor/tools/rangeEdition/speedSection/EditPSLSection.tsx
Show resolved
Hide resolved
front/src/applications/editor/tools/rangeEdition/speedSection/EditPSLSection.tsx
Show resolved
Hide resolved
front/src/applications/editor/tools/rangeEdition/speedSection/EditPSLSection.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/editor/tools/rangeEdition/speedSection/EditPSLSection.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/editor/tools/rangeEdition/speedSection/EditPSLSection.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm o//
09646ae
to
8a39fcc
Compare
Close #4466
Close #5940