Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions: fix release build #6084

Merged
merged 1 commit into from
Dec 11, 2023
Merged

actions: fix release build #6084

merged 1 commit into from
Dec 11, 2023

Conversation

multun
Copy link
Contributor

@multun multun commented Dec 7, 2023

The previous code has a couple of issues:

  • it confused release name and tag name
  • it assigned the tag ref to the release name

@multun multun requested a review from a team as a code owner December 7, 2023 23:03
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a937195) 26.54% compared to head (85e13a7) 26.54%.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #6084   +/-   ##
=========================================
  Coverage     26.54%   26.54%           
  Complexity     2118     2118           
=========================================
  Files           931      931           
  Lines        122892   122892           
  Branches       2664     2664           
=========================================
  Hits          32623    32623           
  Misses        88693    88693           
  Partials       1576     1576           
Flag Coverage Δ
core 78.94% <ø> (ø)
editoast 74.66% <ø> (ø)
front 9.31% <ø> (ø)
gateway 2.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The previous code has a couple of issues:

- it confused release name and tag name
- it assigned the tag ref to the release name
@ElysaSrc
Copy link
Contributor

@multun We need to merge this, and move the 0.2.0 tag ?

@multun multun added this pull request to the merge queue Dec 11, 2023
Merged via the queue into dev with commit 6db066e Dec 11, 2023
17 checks passed
@multun multun deleted the fix-release-build branch December 11, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants