Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: editor - route with/without transit rigid #6188 #6450

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Jan 25, 2024

See #6188

@sim51 sim51 requested a review from a team as a code owner January 25, 2024 12:34
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (0a981cd) 27.94% compared to head (4c759a5) 27.94%.

Files Patch % Lines
...ools/routeEdition/components/RouteEditionPanel.tsx 0.00% 22 Missing ⚠️
...ools/routeEdition/components/RouteEditionLayer.tsx 0.00% 3 Missing ⚠️
...rc/applications/editor/tools/routeEdition/tool.tsx 0.00% 2 Missing ⚠️
...or/tools/routeEdition/components/RouteMetadata.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6450      +/-   ##
============================================
- Coverage     27.94%   27.94%   -0.01%     
  Complexity     2165     2165              
============================================
  Files          1006     1006              
  Lines        126667   126684      +17     
  Branches       2581     2581              
============================================
- Hits          35400    35398       -2     
- Misses        89776    89795      +19     
  Partials       1491     1491              
Flag Coverage Δ
core 78.58% <ø> (ø)
editoast 75.46% <ø> (-0.01%) ⬇️
front 8.69% <0.00%> (-0.01%) ⬇️
gateway 2.50% <ø> (ø)
railjson_generator 87.44% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, just one typo :)

@sim51 sim51 enabled auto-merge January 25, 2024 13:18
@sim51 sim51 added this pull request to the merge queue Jan 25, 2024
Merged via the queue into dev with commit 33626ad Jan 25, 2024
20 checks passed
@sim51 sim51 deleted the bs-issue-6188-2 branch January 25, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants